Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check
From: Nikolay Aleksandrov
Date: Tue Jun 02 2020 - 03:37:16 EST
On 02/06/2020 10:23, Nikolay Aleksandrov wrote:
> On 01/06/2020 21:06, David Miller wrote:
>> From: patrickeigensatz@xxxxxxxxx
>> Date: Mon, 1 Jun 2020 13:12:01 +0200
>>> From: Patrick Eigensatz <patrickeigensatz@xxxxxxxxx>
>>> After allocating the spare nexthop group it should be tested for kzalloc()
>>> returning NULL, instead the already used nexthop group (which cannot be
>>> NULL at this point) had been tested so far.
>>> Additionally, if kzalloc() fails, return ERR_PTR(-ENOMEM) instead of NULL.
>>> Coverity-id: 1463885
>>> Reported-by: Coverity <scan-admin@xxxxxxxxxxxx>
>>> Signed-off-by: Patrick Eigensatz <patrickeigensatz@xxxxxxxxx>
>> Applied, thank you.
> Hi Dave,
> I see this patch in -net-next but it should've been in -net as I wrote in my
> review. This patch should go along with the recent nexthop set that fixes
> a few bugs, since it could result in a null ptr deref if the spare group cannot
> be allocated.
Obviously I forgot to mention in my review that it should go to -stable with the
nexthop fix set.
> How would you like to proceed? Should it be submitted for -net as well?
>  https://lkml.org/lkml/2020/6/1/391