Re: [PATCH] soundwire: clarify SPDX use of GPL-2.0
From: Greg KH
Date: Tue Jun 02 2020 - 05:02:23 EST
On Mon, Jun 01, 2020 at 03:50:13PM -0500, Pierre-Louis Bossart wrote:
>
>
> On 6/1/20 12:38 AM, Greg KH wrote:
> > On Mon, Jun 01, 2020 at 01:28:07AM +0800, Bard Liao wrote:
> > > From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> > >
> > > Change SPDX from GPL-2.0 to GPL-2.0-only for Intel-contributed
> > > code. This was explicit before the transition to SPDX and lost in
> > > translation.
> >
> > It is also explicit in the "GPL-2.0" lines as well, did you read the
> > LICENSES/preferred/GPL-2.0 file for the allowed tags to be used for this
> > license?
> >
> > So this doesn't change anything, and we are trying to cut down on this
> > type of churn until, maybe, after the whole kernel has proper SPDX
> > lines.
>
> My commit message was misleading, sorry. For SoundWire, we recently added
> new files with GPL-2.0-only (master + sysfs), as recommended since the short
> GPL-2.0 identifier is deprecated (https://spdx.org/licenses/GPL-2.0.html
> https://spdx.org/licenses/).
Again, that is the SPDX new list, of course they want to depreciate
older versions. But we started the kernel conversion _before_ the newer
version was there, let's not worry about changing anything at this point
in time as that is unneeded churn.
For new files, fine, pick which ever tag you want to use as documented
in the LICENSES/* files, but do not change existing ones please.
thanks,
greg k-h