Re: [PATCH 4.4 00/48] 4.4.226-rc1 review

[Greg Kroah-Hartman]

On Tue, Jun 02, 2020 at 09:07:15AM +0000, Chris Paterson wrote:
> Hello Sasha,
> 
> > From: stable-owner@xxxxxxxxxxxxxxx <stable-owner@xxxxxxxxxxxxxxx> On
> > Behalf Of Sasha Levin
> > Sent: 02 June 2020 03:07
> > 
> > On Mon, Jun 01, 2020 at 10:14:20PM +0000, Chris Paterson wrote:
> > >Hi Greg,
> > >
> > >> From: stable-owner@xxxxxxxxxxxxxxx <stable-owner@xxxxxxxxxxxxxxx> On
> > >> Behalf Of Greg Kroah-Hartman
> > >> Sent: 01 June 2020 18:53
> > >>
> > >> This is the start of the stable review cycle for the 4.4.226 release.
> > >> There are 48 patches in this series, all will be posted as a response
> > >> to this one.  If anyone has any issues with these being applied, please
> > >> let me know.
> > >
> > >I'm seeing some issues with Linux 4.4.226-rc1 (dc230329b026).
> > >
> > >We have 4 configurations that fail, 2x Armv7 and 2x x86, whilst building the
> > modules.
> > >
> > >Error message:
> > >  ERROR: "pptp_msg_name" [net/netfilter/nf_conntrack_pptp.ko] undefined!
> > >  ERROR: "pptp_msg_name" [net/ipv4/netfilter/nf_nat_pptp.ko] undefined!
> > >
> > >Relevant patches are:
> > >  69969e0f7e37 ("netfilter: nf_conntrack_pptp: prevent buffer overflows in
> > debug code")
> > >  3441cc75e4d1 ("netfilter: nf_conntrack_pptp: fix compilation warning with
> > W=1 build")
> > >
> > >I haven't had a chance to dig deeper yet but will do in the morning.
> > >
> > >Build/test pipeline/logs: https://gitlab.com/cip-project/cip-testing/linux-stable-
> > rc-ci/pipelines/151700917
> > >GitLab CI pipeline: https://gitlab.com/cip-project/cip-testing/linux-cip-
> > pipelines/-/blob/master/trees/linux-4.4.y.yml
> > >Relevant LAVA jobs:
> > https://lava.ciplatform.org/scheduler/alljobs?length=25&search=dc2303#table
> > 
> > Thats and interesting one... I've queued fe22cd9b7c98 ("printk: help
> > pr_debug and pr_devel to optimize out arguments") for 4.4 to address
> > this.
> 
> This patch resolves the issue for me.
> 
> Test pipeline: https://gitlab.com/cip-project/cip-kernel/linux-cip/pipelines/151885545

Thanks for testing -rc2 is out with this fixed.

greg k-h