Re: [PATCH 1/2] video: fbdev: amifb: remove dead APUS support

From: John Paul Adrian Glaubitz
Date: Tue Jun 02 2020 - 06:41:46 EST


Hi Geert!

On 6/2/20 12:37 PM, Bartlomiej Zolnierkiewicz wrote:
>
> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote:
>
>> These #ifdefs are relics from APUS (Amiga Power-Up System), which
>> added a PPC board. APUS support was killed off a long time ago,
>> when arch/ppc/ was still king, but these #ifdefs were missed, because
>> they didn't test for CONFIG_APUS.
>
> Reported-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> ---
> drivers/video/fbdev/amifb.c | 63 --------------------------------------------
> 1 file changed, 63 deletions(-)

What do you mean with the sentence "when arch/ppc/ was still king"?

Does that mean - in the case we would re-add APUS support in the future, that
these particular changes would not be necessary?

I assume there could be new affordable PowerPC upgrade cards for the Amiga
in the future as the PowerPC cards are still sought after by the Amiga
community, so there is still demand for those on the market.

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@xxxxxxxxxx
`. `' Freie Universitaet Berlin - glaubitz@xxxxxxxxxxxxxxxxxxx
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913