Re: [PATCH 05/15] crypto: inside-secure - use PCI_IRQ_MSI_TYPES where appropriate
From: Antoine Tenart
Date: Tue Jun 02 2020 - 07:32:58 EST
Hello Piotr,
Quoting Piotr Stankiewicz (2020-06-02 11:20:19)
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
>
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@xxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Reviewed-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
Thanks,
Antoine
> ---
> drivers/crypto/inside-secure/safexcel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index 2cb53fbae841..1b2faa2a6ab0 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1567,7 +1567,7 @@ static int safexcel_probe_generic(void *pdev,
> ret = pci_alloc_irq_vectors(pci_pdev,
> priv->config.rings + 1,
> priv->config.rings + 1,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + PCI_IRQ_MSI_TYPES);
> if (ret < 0) {
> dev_err(dev, "Failed to allocate PCI MSI interrupts\n");
> return ret;
> --
> 2.17.2
>
--
Antoine TÃnart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com