Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate

[Ulf Hansson]

On Tue, 2 Jun 2020 at 11:21, Piotr Stankiewicz
<piotr.stankiewicz@xxxxxxxxx> wrote:
>
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
>
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@xxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-pci-gli.c     | 3 +--
>  drivers/mmc/host/sdhci-pci-o2micro.c | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index fd76aa672e02..d14997f9cbf9 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -271,8 +271,7 @@ static void gli_pcie_enable_msi(struct sdhci_pci_slot *slot)
>  {
>         int ret;
>
> -       ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1,
> -                                   PCI_IRQ_MSI | PCI_IRQ_MSIX);
> +       ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
>         if (ret < 0) {
>                 pr_warn("%s: enable PCI MSI failed, error=%d\n",
>                        mmc_hostname(slot->host->mmc), ret);
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index fa8105087d68..498c51207bfb 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -470,8 +470,7 @@ static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
>                 return;
>         }
>
> -       ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
> -                                   PCI_IRQ_MSI | PCI_IRQ_MSIX);
> +       ret = pci_alloc_irq_vectors(chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
>         if (ret < 0) {
>                 pr_err("%s: enable PCI MSI failed, err=%d\n",
>                        mmc_hostname(host->mmc), ret);
> --
> 2.17.2
>