Re: [PATCH] x86_64: fix jiffies ODR violation
From: Josh Poimboeuf
Date: Tue Jun 02 2020 - 09:27:25 EST
On Fri, May 15, 2020 at 11:05:40AM -0700, Bob Haarman wrote:
> `jiffies`
[...]
> `jiffies_64`
[...]
> ```
> In LLD, symbol assignments in linker scripts override definitions in
> object files. GNU ld appears to have the same behavior. It would
> probably make sense for LLD to error "duplicate symbol" but GNU ld is
> unlikely to adopt for compatibility reasons.
> ```
Kernel commit logs shouldn't be in Markdown.
Symbol names can just be in single quotes (not back-quotes!) like
'jiffies'.
Quotes can be indented by a few spaces for visual separation, like
In LLD, symbol assignments in linker scripts override definitions in
object files. GNU ld appears to have the same behavior. It would
probably make sense for LLD to error "duplicate symbol" but GNU ld is
unlikely to adopt for compatibility reasons.
or can be formatting like an email quote:
> In LLD, symbol assignments in linker scripts override definitions in
> object files. GNU ld appears to have the same behavior. It would
> probably make sense for LLD to error "duplicate symbol" but GNU ld is
> unlikely to adopt for compatibility reasons.
With Markdown-isms removed from the patch description:
Reviewed-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
--
Josh