Re: [PATCH 2/2] perf tools: Remove some duplicated includes

From: Arnaldo Carvalho de Melo
Date: Tue Jun 02 2020 - 10:10:06 EST


Em Tue, Jun 02, 2020 at 12:15:04PM +0800, Tiezhu Yang escreveu:
> There exists some duplicated includes in tools/perf, remove them.

Applied, thanks.

- Arnaldo

> Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> ---
> tools/perf/builtin-report.c | 1 -
> tools/perf/util/annotate.c | 1 -
> tools/perf/util/auxtrace.c | 1 -
> tools/perf/util/config.c | 1 -
> tools/perf/util/session.c | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index ba63390..5425a2c 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -47,7 +47,6 @@
> #include "util/time-utils.h"
> #include "util/auxtrace.h"
> #include "util/units.h"
> -#include "util/branch.h"
> #include "util/util.h" // perf_tip()
> #include "ui/ui.h"
> #include "ui/progress.h"
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index d828c2d..76bfb4a 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -41,7 +41,6 @@
> #include <linux/bitops.h>
> #include <linux/kernel.h>
> #include <linux/string.h>
> -#include <bpf/libbpf.h>
> #include <subcmd/parse-options.h>
> #include <subcmd/run-command.h>
>
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index 749487a..94a8f4f 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -55,7 +55,6 @@
> #include "util/mmap.h"
>
> #include <linux/ctype.h>
> -#include <linux/kernel.h>
> #include "symbol/kallsyms.h"
> #include <internal/lib.h>
>
> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
> index ef38eba..64f14a5 100644
> --- a/tools/perf/util/config.c
> +++ b/tools/perf/util/config.c
> @@ -20,7 +20,6 @@
> #include "build-id.h"
> #include "debug.h"
> #include "config.h"
> -#include "debug.h"
> #include <sys/types.h>
> #include <sys/stat.h>
> #include <stdlib.h>
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index c11d89e..5550e26e 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -33,7 +33,6 @@
> #include "../perf.h"
> #include "arch/common.h"
> #include <internal/lib.h>
> -#include <linux/err.h>
>
> #ifdef HAVE_ZSTD_SUPPORT
> static int perf_session__process_compressed_event(struct perf_session *session,
> --
> 2.1.0
>

--

- Arnaldo