Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free()

[Dennis Dalessandro]

On 6/2/2020 2:16 AM, YueHaibing wrote:
> dummy_netdev shold be freed by free_netdev() instead of
> kfree(). Also remove unneeded variable 'priv'
>
> Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>   drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
> index 58af6a454761..63688e85e8da 100644
> --- a/drivers/infiniband/hw/hfi1/netdev_rx.c
> +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
> @@ -371,12 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd)
>   
>   void hfi1_netdev_free(struct hfi1_devdata *dd)
>   {
> -	struct hfi1_netdev_priv *priv;
> -
>   	if (dd->dummy_netdev) {
> -		priv = hfi1_netdev_priv(dd->dummy_netdev);
>   		dd_dev_info(dd, "hfi1 netdev freed\n");
> -		kfree(dd->dummy_netdev);
> +		free_netdev(dd->dummy_netdev);
>   		dd->dummy_netdev = NULL;
>   	}
>   }

For the kfree->free_netdev, you probably want to add:
Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Also can add:
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>

Thanks