Re: [PATCH v3 06/10] arm64: dts: actions: Add DMA Controller for S700

[Manivannan Sadhasivam]

On 2 June 2020 11:03:08 PM IST, Amit Singh Tomar <amittomer25@xxxxxxxxx> wrote:
>This commit adds DAM controller present on Actions S700, it differs

DMA

>from
>S900 in terms of number of dma channels and requests.
>
>Signed-off-by: Amit Singh Tomar <amittomer25@xxxxxxxxx>
>---
>Changes since v2:
>	* added power-domain property as sps
>          is enabled now and DMA needs it.
>Changes since v1:
>        * No Change.
>Changes since RFC:
>        * No Change.
>---
> arch/arm64/boot/dts/actions/s700.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/actions/s700.dtsi
>b/arch/arm64/boot/dts/actions/s700.dtsi
>index f8eb72bb4125..605594dd7a0e 100644
>--- a/arch/arm64/boot/dts/actions/s700.dtsi
>+++ b/arch/arm64/boot/dts/actions/s700.dtsi
>@@ -6,6 +6,7 @@
> #include <dt-bindings/clock/actions,s700-cmu.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/actions,s700-reset.h>
>+#include <dt-bindings/power/owl-s700-powergate.h>

Sort this alphabetically. 

Thanks, 
Mani

> 
> / {
> 	compatible = "actions,s700";
>@@ -244,5 +245,19 @@
> 				     <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> 				     <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> 		};
>+
>+		dma: dma-controller@e0230000 {
>+			compatible = "actions,s700-dma";
>+			reg = <0x0 0xe0230000 0x0 0x1000>;
>+			interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
>+				     <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
>+				     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
>+				     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
>+			#dma-cells = <1>;
>+			dma-channels = <10>;
>+			dma-requests = <44>;
>+			clocks = <&cmu CLK_DMAC>;
>+			power-domains = <&sps S700_PD_DMA>;
>+		};
> 	};
> };

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.