Re: [PATCH v2] usb/phy-generic: Add support for OTG VBUS supply control

[Mike Looijmans]

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@xxxxxxxxxxxxxxxxx
W: www.topicproducts.com

Please consider the environment before printing this e-mail
On 29-05-2020 23:08, Rob Herring wrote:
> On Fri, May 29, 2020 at 08:00:45AM +0200, Mike Looijmans wrote:
> > This enables support for VBUS on boards where the power is supplied
> > by a regulator. The regulator is enabled when the USB port enters
> > HOST mode.
> >
> > Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx>
> > ---
> > v2: Added missing "return 0;" in set_vbus method
> >
> >   .../devicetree/bindings/usb/usb-nop-xceiv.txt |  3 ++
> >   drivers/usb/phy/phy-generic.c                 | 46 ++++++++++++++++++-
> >   drivers/usb/phy/phy-generic.h                 |  2 +
> >   3 files changed, 50 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
> > index 4dc6a8ee3071..775a19fdb613 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
> > @@ -16,6 +16,9 @@ Optional properties:
> >   
> >   - vcc-supply: phandle to the regulator that provides power to the PHY.
> >   
> > +- vbus-supply: phandle to the regulator that provides the VBUS power for when
> > +  the device is in HOST mode.
> > +
> I'm going to say no to expanding this binding...
>
> First, there sure are a lot of controls on a NOP tranceiver.
>
> Second, unless Vbus is supplying the PHY, then this belongs in a
> connector node for which this is already supported.

Clear, I moved the implementation to the DWC3 driver and will submit a 
new patch for that.


> >   - reset-gpios: Should specify the GPIO for reset.
> >   
> >   - vbus-detect-gpio: should specify the GPIO detecting a VBus insertion


--
Mike Looijmans