RE: [RESENT PATCH v5 0/5] scsi: ufs: cleanup ufs initialization

From: Avri Altman
Date: Wed Jun 03 2020 - 06:33:17 EST


Looks fine to me.
Thanks,
Avri


>
> From: Bean Huo <beanhuo@xxxxxxxxxx>
>
> Resent this patchset since linux-scsi@xxxxxxxxxxxxxxx and
> linux-kernel@xxxxxxxxxxxxxxx rejected my email
>
>
> Cleanup UFS descriptor length initialization, and delete some unnecessary
> code.
>
> Changelog:
> v4 - v5:
> 1. Rebased patch
> 2. In the patch 3/5, change "param_size > buff_len" to
> "(param_offset + param_size) > buff_len"
>
> v3 - v4:
> 1. add desc_id >= QUERY_DESC_IDN_MAX check in patch 4/5 (Avri Altman)
> 2. update buff_len to hold the true descriptor size in 4/5 (Avri Altman)
> 3. add new patch 3/5
>
> v2 - v3:
> 1. Fix typo in the commit message (Avri Altman & Bart van Assche)
> 2. Delete ufshcd_init_desc_sizes() in patch 3/4 (Stanley Chu)
> 3. Remove max_t() and buff_len in patch 1/4 (Bart van Assche)
> 4. Add patch 4/4 to compatable with 3.1 UFS unit descriptor length
>
> v1 - v2:
> 1. split patch
> 2. fix one compiling WARNING (Reported-by: kbuild test robot
> <lkp@xxxxxxxxx>)
>
> Bart van Assche (1):
> scsi: ufs: remove max_t in ufs_get_device_desc
>
> Bean Huo (4):
> scsi: ufs: delete ufshcd_read_desc()
> scsi: ufs: fix potential access NULL pointer while memcpy
> scsi: ufs: cleanup ufs initialization path
> scsi: ufs: add compatibility with 3.1 UFS unit descriptor length
>
> drivers/scsi/ufs/ufs.h | 11 +-
> drivers/scsi/ufs/ufs_bsg.c | 5 +-
> drivers/scsi/ufs/ufshcd.c | 207 +++++++++----------------------------
> drivers/scsi/ufs/ufshcd.h | 16 +--
> 4 files changed, 54 insertions(+), 185 deletions(-)
>
> --
> 2.17.1