Re: [PATCH 1/4] sched/pelt: Remove redundant cap_scale() definition

[Vincent Guittot]

On Wed, 3 Jun 2020 at 10:03, Dietmar Eggemann <dietmar.eggemann@xxxxxxx> wrote:
>
> Besides in PELT cap_scale() is used in the Deadline scheduler class for
> scale-invariant bandwidth enforcement.
> Remove the cap_scale() definition in kernel/sched/pelt.c and keep the
> one in kernel/sched/sched.h.
>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>

Reviewed-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> ---
>  kernel/sched/pelt.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/pelt.c b/kernel/sched/pelt.c
> index b4b1ff96642f..dea5567e4f72 100644
> --- a/kernel/sched/pelt.c
> +++ b/kernel/sched/pelt.c
> @@ -83,8 +83,6 @@ static u32 __accumulate_pelt_segments(u64 periods, u32 d1, u32 d3)
>         return c1 + c2 + c3;
>  }
>
> -#define cap_scale(v, s) ((v)*(s) >> SCHED_CAPACITY_SHIFT)
> -
>  /*
>   * Accumulate the three separate parts of the sum; d1 the remainder
>   * of the last (incomplete) period, d2 the span of full periods and d3
> --
> 2.17.1
>