Re: [PATCH v2 3/7] selftests/ftrace: Add "requires:" list support

[Steven Rostedt]

On Wed, 3 Jun 2020 08:51:13 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> On Tue, 2 Jun 2020 09:21:45 -0400
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> 
> > On Tue,  2 Jun 2020 18:08:31 +0900
> > Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> >   
> > > +++ b/tools/testing/selftests/ftrace/test.d/template
> > > @@ -1,6 +1,7 @@
> > >  #!/bin/sh
> > >  # SPDX-License-Identifier: GPL-2.0
> > >  # description: %HERE DESCRIBE WHAT THIS DOES%
> > > +# requires: %HERE LIST UP REQUIRED FILES%  
> > 
> > Not sure what you mean by "LIST UP". Perhaps you mean "LIST OF"?  
> 
> Ah, perhups we don't need UP. "list the required files" will be OK?
> 
>

Yes, that sounds much better.

I tested out the patches with a few different configurations, and they all
look good.

Although I found that the irqsoff_tracer.tc (test for the preemptirqsoff
tracer) changed from UNRESOLVED to UNSUPPORTED.

I'll run a few more different configs and see what happens, but you can add:

Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve