Re: v5.7: new core kernel option missing help text

From: Valentin Schneider
Date: Wed Jun 03 2020 - 14:00:32 EST



On 03/06/20 18:31, Russell King - ARM Linux admin wrote:
> Hi,
>
> A new kernel configuration option ("SCHED_THERMAL_PRESSURE") was
> recently added, but has no help text. This is most unhelpful when
> trying to configure the kernel, since one does not know what the
> effect of answering yes or no to this option would be.
>
> Please supply a proper help text when adding core kernel options
> so that people can make an informed decision when answering the
> prompt, rather than just guessing.
>

Right; does the below look good enough?

---
diff --git a/init/Kconfig b/init/Kconfig
index 74a5ac65644f..f40cf852d00a 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -441,6 +441,10 @@ config HAVE_SCHED_AVG_IRQ
config SCHED_THERMAL_PRESSURE
bool "Enable periodic averaging of thermal pressure"
depends on SMP
+ help
+ This option allows the scheduler to be aware of CPU thermal throttling
+ (i.e. thermal pressure), providing arch_scale_thermal_pressure() is
+ implemented.

config BSD_PROCESS_ACCT
bool "BSD Process Accounting"
---