Re: [GIT PULL for v5.8-rc1] media updates

From: Mauro Carvalho Chehab
Date: Thu Jun 04 2020 - 02:20:58 EST


Em Wed, 3 Jun 2020 21:21:06 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> escreveu:

> On Wed, Jun 3, 2020 at 1:06 AM Mauro Carvalho Chehab
> <mchehab+huawei@xxxxxxxxxx> wrote:
> >
> > - The atomisp staging driver was resurrected. It is meant to work with
> > 4 generations of cameras on Atom-based laptops, tablets and cell
> > phones. So, it seems worth investing time to cleanup this driver and
> > making it in good shape.
>
> Hmm. It causes a warning for me:
>
> drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: warning:
> âatomisp_mrfld_powerâ defined but not used [-Wunused-function]
>
> which is a bit annoying.
>
> I can see the FIXME's there, but the warning still isn't acceptable.
>
> I'll add a fixup commit. I was going to do it in the merge itself, but
> decided that was a bit too subtle.

OK!

I have a patch like that already on a separate pile of patches,
which address several other things. I opted to place them in
separate, in order to give people some time to comment and review.

My plan is to keep them on linux-next and submit you next week, if
ok for you.

The new series should drop all LLVM warnings and add SPDX headers,
among other things.

Thanks,
Mauro