Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

From: Chaitanya Kulkarni
Date: Thu Jun 04 2020 - 02:54:14 EST

On 6/3/20 11:46 PM, Dongli Zhang wrote:
> May I get feedback for this?
> For the first time I use fcloop, I set:
> # echo "wwnn=0x3,wwpn=0x1" > /sys/class/fcloop/ctl/add_target_port
> However, I would not be able to move forward if I use "0x3" or "0x1" for nvme-fc
> target or host further. Instead, the address and port should be
> 0x0000000000000003 and 0x0000000000000001.
> This patch would sync the requirements of input format for nvme-fc and
> nvme-fcloop, unless this would break existing test suite (e.g., blktest).
If I remember correctly I don't think we have fc-loop testcases (correct
me if I'm wrong).

Not an fc expert, but having uniform format for the input make sense to
me (unless there is an explicit reason). I'll let James have a final say.