Re: [PATCH v3 2/2] checks: Improve i2c reg property checking
From: David Gibson
Date: Thu Jun 04 2020 - 03:15:03 EST
On Tue, Jun 02, 2020 at 11:28:05AM +0300, Andy Shevchenko wrote:
> On Tue, Jun 2, 2020 at 11:03 AM Serge Semin
> <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Thu, May 28, 2020 at 06:26:50PM +0930, Joel Stanley wrote:
> > > +#define I2C_TEN_BIT_ADDRESS (1 << 31)
> > As Andy neatly pointed out here:
> > https://lore.kernel.org/lkml/20200527133656.GV1634618@xxxxxxxxxxxxxxxxxx/
> > (1 << 31) is UB.
> Thanks, Serge. Yes, we have to use 1U in the definitions (for 31 is
> necessary, for the rest is for the sake of consistency).
Joel, I know it seems trivial, but I'm a bit flat out right now. Can
you please resend with the 1U fix applied.
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
Description: PGP signature