Re: [RFC 2/4] regulator: lp87565: dt: remove duplicated section
From: Luca Ceresoli
Date: Thu Jun 04 2020 - 04:45:01 EST
thanks for the very prompt review!
On 04/06/20 08:47, Lee Jones wrote:
> On Wed, 03 Jun 2020, Luca Ceresoli wrote:
>> The "Required properties:" section is copied verbatim for each of the two
>> supported chips. In preparation to add a new chip variant make it a common
>> section and keep the two examples to differentiate between the two chips.
>> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
>> .../devicetree/bindings/mfd/lp87565.txt | 21 ++++---------------
>> 1 file changed, 4 insertions(+), 17 deletions(-)
>> diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
>> index 41671e0dc26b..b75ae23a1ef3 100644
>> --- a/Documentation/devicetree/bindings/mfd/lp87565.txt
>> +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
>> @@ -1,7 +1,7 @@
>> TI LP87565 PMIC MFD driver
>> Required properties:
>> - - compatible: "ti,lp87565", "ti,lp87565-q1"
>> + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1"
> What happened to your tabbing here?
Looks weird, but I actually fixed it. The patch format is misleading, it
you look at the file you'll see there's a missing tab there before the
patch. Hm, guess I should have mentioned it in the commit message, will
do in v2.
> All the other entries start with a capital letter. So should this.