Re: [PATCH RFC 04/13] vhost: cleanup fetch_buf return code handling

From: Michael S. Tsirkin
Date: Thu Jun 04 2020 - 05:01:26 EST


On Wed, Jun 03, 2020 at 03:29:02PM +0800, Jason Wang wrote:
>
> On 2020/6/2 äå9:06, Michael S. Tsirkin wrote:
> > Return code of fetch_buf is confusing, so callers resort to
> > tricks to get to sane values. Let's switch to something standard:
> > 0 empty, >0 non-empty, <0 error.
> >
> > Signed-off-by: Michael S. Tsirkin<mst@xxxxxxxxxx>
> > ---
> > drivers/vhost/vhost.c | 24 ++++++++++++++++--------
> > 1 file changed, 16 insertions(+), 8 deletions(-)
>
>
> Why not squashing this into patch 2 or 3?
>
> Thanks

It makes the tricky patches smaller. I'll consider it,
for now this split is also because patches 1-3 have
already been tested.

--
MST