Re: [PATCH v3 1/6] PCI: dwc: Add msi_host_isr() callback

[Kunihiko Hayashi]

Hi Marc,

On 2020/06/03 20:15, Marc Zyngier wrote:
> On 2020-06-03 09:54, Kunihiko Hayashi wrote:
> > This adds msi_host_isr() callback function support to describe
> > SoC-dependent service triggered by MSI.
> >
> > For example, when AER interrupt is triggered by MSI, the callback function
> > reads SoC-dependent registers and detects that the interrupt is from AER,
> > and invoke AER interrupts related to MSI.
> >
> > Cc: Marc Zyngier <maz@xxxxxxxxxx>
> > Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
> > Cc: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > ---
> > Âdrivers/pci/controller/dwc/pcie-designware-host.c | 8 ++++----
> > Âdrivers/pci/controller/dwc/pcie-designware.hÂÂÂÂÂ | 1 +
> > Â2 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c
> > b/drivers/pci/controller/dwc/pcie-designware-host.c
> > index 0a4a5aa..9b628a2 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> > @@ -112,13 +112,13 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp)
> > Âstatic void dw_chained_msi_isr(struct irq_desc *desc)
> > Â{
> > ÂÂÂÂ struct irq_chip *chip = irq_desc_get_chip(desc);
> > -ÂÂÂ struct pcie_port *pp;
> > +ÂÂÂ struct pcie_port *pp = irq_desc_get_handler_data(desc);
> >
> > -ÂÂÂ chained_irq_enter(chip, desc);
> > +ÂÂÂ if (pp->ops->msi_host_isr)
> > +ÂÂÂÂÂÂÂ pp->ops->msi_host_isr(pp);
>
> Why is this call outside of the enter/exit guards?
> Do you still need to execute the standard handler?

I assume that the msi_host_isr() contains chained interrupts in
the second patch and no need to treat as the standard handler,
so this should be called in the guards.
I'll move this call to the top of dw_chained_msi_isr().

Thank you,

---
Best Regards
Kunihiko Hayashi