Re: [PATCH 0/6] leds: fix broken devres usage

From: Pavel Machek
Date: Thu Jun 04 2020 - 09:31:51 EST


Hi!

> Several MFD child drivers register their class devices directly under
> the parent device (about half of the MFD LED drivers do so).
>
> This means you cannot blindly do devres conversions so that
> deregistration ends up being tied to the parent device, something which
> leads to use-after-free on driver unbind when the class device is
> released while still being registered (and, for example, oopses on later
> parent MFD driver unbind or LED class callbacks, or resource leaks and
> name clashes on child driver reload).
>
> Included is also a clean up removing some pointless casts when
> registering class devices.
>
> All but the lm3533 one have only been compile tested.

It would be nicer to have devres framework work with these... but I
guess this should go in...

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature