Re: [PATCH v2 1/2] arm64: dts: Add a device tree for the Librem 5 phone

[Mark Brown]

On Thu, Jun 04, 2020 at 10:47:55AM +0200, Martin Kepplinger wrote:

> +	reg_audio_pwr_en: regulator-audio-pwr-en {
> +		compatible = "regulator-fixed";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_audiopwr>;
> +		regulator-name = "AUDIO_PWR_EN";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		gpio = <&gpio1 4 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
> +	reg_aud_1v8: regulator-audio-1v8 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "AUD_1V8";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		vin-supply = <&reg_audio_pwr_en>;
> +	};

This looks broken - a combination of the structure, lack of any
references to reg_audio_pwr_en and the naming suggests that you have one
regulator here for a supply called AUD_1V8 which has a GPIO controlling
the enable.  I can't figure out any reason for reg_audio_pwr_en.

> +	sound {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,name = "wm8962";

You might want to put a more user friendly display name here (eg, one
mentioning Librem 5) - some UIs will show this string to users.

Attachment: signature.asc
Description: PGP signature