Re: [PATCH v5 0/2] Small devm helper for devm implementations

From: Marc Gonzalez
Date: Thu Jun 04 2020 - 12:14:43 EST

Looks like this series has fallen through the cracks :(
Greg, you would be taking the drivers/base/devres.c changes?
As mentioned in patch 2, "This patch needs testing on a platform with many clocks."
(I've only tested using a trivial kernel module)

On 10/03/2020 11:11, Marc Gonzalez wrote:

> Differences from v4 to v5
> x Fix the grammar in devm_add comments [Geert]
> x Undo an unrelated change in devm_clk_put [Geert]
> Differences from v3 to v4
> x Add a bunch of kerneldoc above devm_add() [Greg KH]
> x Split patch in two [Greg KH]
> Differences from v2 to v3
> x Make devm_add() return an error-code rather than the raw data pointer
> (in case devres_alloc ever returns an ERR_PTR) as suggested by Geert
> x Provide a variadic version devm_vadd() to work with structs as suggested
> by Geert
> x Don't use nested ifs in clk_devm* implementations (hopefully simpler
> code logic to follow) as suggested by Geert
> Marc Gonzalez (2):
> devres: Provide new helper for devm functions
> clk: Use devm_add in managed functions
> drivers/base/devres.c | 28 ++++++++++++
> drivers/clk/clk-devres.c | 97 +++++++++++++++-------------------------
> include/linux/device.h | 3 ++
> 3 files changed, 67 insertions(+), 61 deletions(-)