Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

From: Dan Murphy
Date: Thu Jun 04 2020 - 12:38:28 EST


On 6/4/20 11:25 AM, Jakub Kicinski wrote:
On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote:
Add RGMII internal delay configuration for Rx and Tx.

Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
Hi Dan, please make sure W=1 C=1 build is clean:

drivers/net/phy/dp83869.c:103:18: warning: ÃâËdp83869_internal_delayÃââ defined but not used [-Wunused-const-variable=]
103 | static const int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500,
| ^~~~~~~~~~~~~~~~~~~~~~

I built with W=1 and C=1 and did not see this warning.

What defconfig are you using?

Can you check if CONFIG_OF_MDIO is set or not? That would be the only way that warning would come up.

Also net-next is closed right now, you can post RFCs but normal patches
should be deferred until after net-next reopens.

I know net-next is closed.

I pinged David M when it was open about what is meant by "new" patches in the net-dev FAQ. So I figured I would send the patches to see what the response was.

To me these are not new they are in process patches. My understand is New is v1 patchesets.

But now I have the answer.