Re: [PATCH v3 0/4] forbid fix {SQ,IO}POLL

From: Jens Axboe
Date: Thu Jun 04 2020 - 13:06:17 EST


On 6/3/20 12:51 PM, Jens Axboe wrote:
> On 6/3/20 9:03 AM, Pavel Begunkov wrote:
>> The first one adds checks {SQPOLL,IOPOLL}. IOPOLL check can be
>> moved in the common path later, or rethinked entirely, e.g.
>> not io_iopoll_req_issued()'ed for unsupported opcodes.
>>
>> 3 others are just cleanups on top.
>>
>>
>> v2: add IOPOLL to the whole bunch of opcodes in [1/4].
>> dirty and effective.
>> v3: sent wrong set in v2, re-sending right one
>>
>> Pavel Begunkov (4):
>> io_uring: fix {SQ,IO}POLL with unsupported opcodes
>> io_uring: do build_open_how() only once
>> io_uring: deduplicate io_openat{,2}_prep()
>> io_uring: move send/recv IOPOLL check into prep
>>
>> fs/io_uring.c | 94 ++++++++++++++++++++++++++-------------------------
>> 1 file changed, 48 insertions(+), 46 deletions(-)
>
> Thanks, applied.

#1 goes too far, provide/remove buffers is fine with iopoll. I'll
going to edit the patch.

--
Jens Axboe