Re: [PATCH 4.19 12/80] pppoe: only process PADT targeted at local interfaces

[David BalaÅic]

Hi!

Is there a good reason this did not land in 4.14 branch?

Openwrt is using that and so it missed this patch.

Any chance it goes in in next round?

Regards,
David

On Mon, 18 May 2020 at 19:50, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Guillaume Nault <gnault@xxxxxxxxxx>
>
> [ Upstream commit b8c158395119be62294da73646a3953c29ac974b ]
>
> We don't want to disconnect a session because of a stray PADT arriving
> while the interface is in promiscuous mode.
> Furthermore, multicast and broadcast packets make no sense here, so
> only PACKET_HOST is accepted.
>
> Reported-by: David BalaÅic <xerces9@xxxxxxxxx>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Guillaume Nault <gnault@xxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/ppp/pppoe.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> --- a/drivers/net/ppp/pppoe.c
> +++ b/drivers/net/ppp/pppoe.c
> @@ -497,6 +497,9 @@ static int pppoe_disc_rcv(struct sk_buff
>         if (!skb)
>                 goto out;
>
> +       if (skb->pkt_type != PACKET_HOST)
> +               goto abort;
> +
>         if (!pskb_may_pull(skb, sizeof(struct pppoe_hdr)))
>                 goto abort;
>
>
>