Re: [PATCH 4.19 12/80] pppoe: only process PADT targeted at local interfaces

From: David BalaÅic
Date: Thu Jun 04 2020 - 18:31:45 EST


On Thu, 4 Jun 2020 at 22:17, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Jun 04, 2020 at 08:39:00PM +0200, David BalaÅic wrote:
> > Hi!
> >
> > Is there a good reason this did not land in 4.14 branch?
> >
> > Openwrt is using that and so it missed this patch.
> >
> > Any chance it goes in in next round?
>
> Does it apply and build cleanly?
>
> I don't know why I didn't backport it further, something must have
> broke...

The patch from the above applies to linux-4.14.183

If I apply it manually (open pppoe.c in editor and add the two lines
from the patch) then it builds.
Until LD vmlinux.o when I run out of disk space...
I applied it by editor because the first time something went wrong
when copying the patch from the email and it did not apply.

So it looks OK, but someone else should try it too.
My build system is not exactly great.. (it is a VM I created for
openwrt builds and it is after midnight and I don't feel like
extending the virtual disk.. sorry, maybe tomorrow).

Regards,
David