Re: [PATCH 1/2] MIPS: set page access bit with pgprot on some MIPS platform

From: Jiaxun Yang
Date: Fri Jun 05 2020 - 05:39:34 EST


On Fri, 5 Jun 2020 17:11:05 +0800
Bibo Mao <maobibo@xxxxxxxxxxx> wrote:

> On MIPS system which has rixi hardware bit, page access bit is not
> set in pgrot. For memory reading, there will be one page fault to
> allocate physical page; however valid bit is not set, there will
> be the second fast tlb-miss fault handling to set valid/access bit.
>
> This patch set page access/valid bit with pgrot if there is reading
> access privilege. It will reduce one tlb-miss handling for memory
> reading access.
>
> The valid/access bit will be cleared in order to track memory
> accessing activity. If the page is accessed, tlb-miss fast handling
> will set valid/access bit, pte_sw_mkyoung is not necessary in slow
> page fault path. This patch removes pte_sw_mkyoung function which
> is defined as empty function except MIPS system.
>
> Signed-off-by: Bibo Mao <maobibo@xxxxxxxxxxx>
> ---

Thanks for tracking it down.

Could you please make the patch tittle more clear?
"Some" looks confuse to me, "systems with RIXI" would be better.

- Jiaxun