Re: v5.7: new core kernel option missing help text
From: Valentin Schneider
Date: Fri Jun 05 2020 - 05:46:17 EST
On 05/06/20 08:03, Vincent Guittot wrote:
> On Thu, 4 Jun 2020 at 17:38, Valentin Schneider
> <valentin.schneider@xxxxxxx> wrote:
>> ---
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 16fbf74030fe..1e92080dc275 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -46,6 +46,7 @@ config ARM
>> select EDAC_ATOMIC_SCRUB
>> select GENERIC_ALLOCATOR
>> select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY
>> + select SCHED_THERMAL_PRESSURE if GENERIC_ARCH_TOPOLOGY
>
> I think that SCHED_THERMAL_PRESSURE depends on ARM_CPU_TOPOLOGY but
> not on GENERIC_ARCH_TOPOLOGY.
> ARM_CPU_TOPOLOGY is used to define arch_scale_thermal_pressure for arm
> architecture
> and we only use the header file of the generic arch_topology.h.
> Function like arch_set_thermal_pressure() is in sched/core.c
>
You're right, oh well... Let me spend a bit more time on this and I'll
send actual patches.