Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB

[Geert Uytterhoeven]

Hi Prabhakar,

On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> Add support for the camera daughter board which is connected to
> iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> ethernet1 interfaces.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- /dev/null
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts

> +&scifb1 {
> +       pinctrl-0 = <&scifb1_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";

Before I queue this in renesas-devel for v5.9, I have on question:
As this port carries RTS/CTS signals, perhaps you want to add

    rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
    cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;

?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds