Re: [Possible PATCH] iommu/qcom: Change CONFIG_BIG_ENDIAN to CONFIG_CPU_BIG_ENDIAN

[Rob Clark]

On Sat, Jun 6, 2020 at 12:16 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> CONFIG_BIG_ENDIAN does not exist as a Kconfig symbol.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
>
> I don't have the hardware, so I can't tell if this is a
> correct change, but it is a logical one.

I'm not sure *anyone* has a working snapdragon big-endian setup these
days.. sboyd used to tinker with that ages ago.

But, SCTLR.E is the bit to set for big-endian, so this looks like the
right thing to do.

Reviewed-by: Rob Clark <robdclark@xxxxxxxxx>

> Found by a test script that looks for IS_ENABLED(FOO)
> where FOO must also exist in Kconfig files.
>
>  drivers/iommu/qcom_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
> index c3e1fbd1988c..69e113471ecb 100644
> --- a/drivers/iommu/qcom_iommu.c
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -304,7 +304,7 @@ static int qcom_iommu_init_domain(struct iommu_domain *domain,
>                       ARM_SMMU_SCTLR_M | ARM_SMMU_SCTLR_S1_ASIDPNE |
>                       ARM_SMMU_SCTLR_CFCFG;
>
> -               if (IS_ENABLED(CONFIG_BIG_ENDIAN))
> +               if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
>                         reg |= ARM_SMMU_SCTLR_E;
>
>                 iommu_writel(ctx, ARM_SMMU_CB_SCTLR, reg);
>