Re: [PATCH net v1] net: dsa: lantiq_gswip: fix and improve the unsupported interface error

From: David Miller
Date: Sun Jun 07 2020 - 20:10:10 EST


From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
Date: Sun, 7 Jun 2020 15:02:58 +0200

> While trying to use the lantiq_gswip driver on one of my boards I made
> a mistake when specifying the phy-mode (because the out-of-tree driver
> wants phy-mode "gmii" or "mii" for the internal PHYs). In this case the
> following error is printed multiple times:
> Unsupported interface: 3
>
> While it gives at least a hint at what may be wrong it is not very user
> friendly. Print the human readable phy-mode and also which port is
> configured incorrectly (this hardware supports ports 0..6) to improve
> the cases where someone made a mistake.
>
> Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

Looks good, applied, thank you.