Re: [PATCH -next 0/3] s390: use scnprintf() in show() methods
From: Heiko Carstens
Date:  Mon Jun 08 2020 - 10:28:38 EST
On Sat, May 09, 2020 at 04:56:05PM +0800, Chen Zhou wrote:
> snprintf() returns the number of bytes that would be written,
> which may be greater than the the actual length to be written.
> 	    
> show() methods should return the number of bytes printed into the
> buffer. This is the return value of scnprintf().
> 
> Chen Zhou (3):
>   s390/crypto: use scnprintf() instead of snprintf()
>   s390: use scnprintf() in sys_##_prefix##_##_name##_show
>   s390/protvirt: use scnprintf() instead of snprintf()
> 
>  arch/s390/crypto/prng.c | 14 +++++++-------
>  arch/s390/kernel/ipl.c  |  2 +-
>  arch/s390/kernel/uv.c   |  8 ++++----
>  3 files changed, 12 insertions(+), 12 deletions(-)
All applied, even though the buffer has a size of 4k in all cases.
So this doesn't fix anything; but it doesn't hurt as well.