Re: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for xen_start_kernel()

[Boris Ostrovsky]

On 6/6/20 10:27 AM, Benjamin Thiel wrote:
> Fix:
>
>   arch/x86/xen/enlighten_pv.c:1212:34:
>   warning: no previous prototype for âxen_start_kernelâ [-Wmissing-prototypes]
>   asmlinkage __visible void __init xen_start_kernel(void)
>
> Add a prototype for xen_start_kernel() in a separate xen-specific header.


TBH I am not sure it's worth a new header file for a routine that is
only called from assembly (and never returns). I'd just add the
prototype right above function definition, with a comment describing
why. I see a few examples of this in the tree. Or maybe we even have an
attribute for this case?


(I also suspect the same may be needed for xen_prepare_pvh() BTW).


-boris