Re: [PATCH 1/2] dt-bindings: watchdog: intel: Add YAML Schemas for Watchdog timer

[Guenter Roeck]

On 6/9/20 1:57 AM, Dilip Kota wrote:
> 
> On 6/8/2020 9:37 PM, Guenter Roeck wrote:
>> On 6/7/20 10:49 PM, Dilip Kota wrote:
>>> Add YAML schemas for the watchdog timer on Intel Lightning
>>> Mountain SoC.
>>>
>>> Signed-off-by: Dilip Kota <eswara.kota@xxxxxxxxxxxxxxx>
>>> ---
>>> Â .../bindings/watchdog/intel,lgm-gptc-wdt.yamlÂÂÂÂÂ | 75 ++++++++++++++++++++++
>>> Â 1 file changed, 75 insertions(+)
>>> Â create mode 100644 Documentation/devicetree/bindings/watchdog/intel,lgm-gptc-wdt.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/intel,lgm-gptc-wdt.yaml b/Documentation/devicetree/bindings/watchdog/intel,lgm-gptc-wdt.yaml
>>> new file mode 100644
>>> index 0000000000000..83dc39a5090c1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/watchdog/intel,lgm-gptc-wdt.yaml
>>> @@ -0,0 +1,75 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/watchdog/intel,lgm-gptc-wdt.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Intel Lightning Mountain Watchdog timer.
>>> +
>>> +maintainers:
>>> +Â - Dilip Kota <eswara.kota@xxxxxxxxxxxxxxx>
>>> +
>>> +description: |
>>> +Â Intel Lightning Mountain SoC has General Purpose Timer Counter(GPTC) which can
>>> +Â be configured as Clocksource, real time clock and Watchdog timer.
>>> +Â Each General Purpose Timer Counter has three timers. And total four General
>>> +Â Purpose Timer Counters are present on Lightning Mountain SoC which sums up
>>> +Â to 12 timers.
>>> +Â Lightning Mountain has four CPUs and each CPU is configured with one GPTC
>>> +Â timer as watchdog timer. Total four timers are configured as watchdog timers
>>> +Â on Lightning Mountain SoC.
>>> +
>> Why not just one ? The watchdog subsystem does not monitor individual CPUs,
>> it monitors the system.
> 
> Intel Atom based Lightning Mountain SoC, system has four CPUs. On Lightning Mountain SoC ,Watchdog subsystem is combination of GPTC timers and reset controller unit. On Lightning Mountain SoC, each CPU is configured with one GPTC timer, so that if any of the CPU hangs or freezes, the watchdog daemon running on respective CPU cannot reset/ping or pet the watchdog timer. This causes the watchdog timeout. On watchdog timeout, reset controller triggers the reset to respective CPU.
> 
A system watchdog driver should not duplicate functionality
from kernel/watchdog.c, which monitors individual CPUs.
If the SoC does nto provide a system watchdog timer (which
I think is unlikely), it should stick with that. A watchdog
resetting an individual CPU instead of the entire system
isn't something I would want to see in the watchdog subsystem.

Guenter

> 
> ____________________
> ----------------------------->| ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | Â Â Â Â ------------>| Reset controller unitÂÂÂ |
> |ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |___________________|
> |ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |
> |ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |
> Â ______________________|__________|______
> Â | Â Â Â Â Â Â Â ÂÂ ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ GPTCÂÂ | |ÂÂ Â Â Â ÂÂ |
> Â | ___________ÂÂ ________|_ Â ÂÂÂ ______|____ÂÂ |
> Â | | Â ÂÂ timer 1 |ÂÂ | timer 2 Â ÂÂ | ÂÂ | timer 3ÂÂÂÂÂ |ÂÂÂ |
> Â | |_________|ÂÂ |_________|ÂÂÂ |_________|ÂÂÂ |
> Â |______________________________________|
> 
> Regards,
> -Dilip
> 
> 
>> Guenter
>>
>>