Re: [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create()

[Markus Elfring]

> In fucntin msm_submitqueue_create, the queue is a local
> variable, in return -EINVAL branch, queue didn`t add to ctx`s
> list yet, and also didn`t kfree, this maybe bring in potential
> memleak.

I suggest to improve also this change description.
How do you think about a wording variant like the following?

   Release the GPU submission queue object after an input parameter validation failed.


Would you like to add the tag âFixesâ to the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n183


How do you think about to reorder any statements for this function implementation?

Regards,
Markus