Re: [PATCH RT 3/4] tasklet: Fix UP case for tasklet CHAINED state

From: Sebastian Andrzej Siewior
Date: Fri Jun 12 2020 - 09:09:56 EST


On 2020-06-11 13:10:16 [-0500], zanussi@xxxxxxxxxx wrote:
> commit 62d0a2a30cd0 (tasklet: Address a race resulting in
> double-enqueue) addresses a problem that can result in a tasklet being
> enqueued on two cpus at the same time by combining the RUN flag with a
> new CHAINED flag, and relies on the combination to be present in order
> to zero it out, which can never happen on (!SMP and !PREEMPT_RT_FULL)
> because the RUN flag is SMP/PREEMPT_RT_FULL-only.
>
> So make sure the above commit is only applied for the SMP ||
> PREEMPT_RT_FULL case.
>
> Fixes: 62d0a2a30cd0 ("tasklet: Address a race resulting in double-enqueue")
> Signed-off-by: Tom Zanussi <zanussi@xxxxxxxxxx>
> Reported-by: Ramon Fried <rfried.dev@xxxxxxxxx>
> Tested-By: Ramon Fried <rfried.dev@xxxxxxxxx>

Acked-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Sebastian