Re: RFC: a failing pm_runtime_get increases the refcnt?

[Wolfram Sang]

Hi Geert and Rafael,

> > I've always[*] considered a pm_runtime_get_sync() failure to be fatal
> > (or: cannot happen), and that there's nothing that can be done to
> > recover.  Hence I never checked the function's return value.
> > Was that wrong?
> 
> No, it wasn't.  It is the right thing to do in the majority of cases.

OK, if *not checking* the retval is the major use case, then I
understand that ref counting takes place.

However, that probably means that for most patches I am getting, the
better fix would be to remove the error checking? (I assume most people
put the error check in there to be on the "safe side" without having a
real argument to really do it.)

And thanks for putting more hints to kernel doc! I think this will help
the case a lot.

Kind regards,

   Wolfram

Attachment: signature.asc
Description: PGP signature