Re: [PATCH 2/2] bitmap: Add test for bitmap_cut()

From: Alexander Gordeev
Date: Mon Jun 15 2020 - 08:05:06 EST


On Mon, Jun 15, 2020 at 12:46:16PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 15, 2020 at 12:41:55PM +0300, Andy Shevchenko wrote:
> > On Sun, Jun 14, 2020 at 07:40:54PM +0200, Stefano Brivio wrote:
> > > Inspired by an original patch from Yury Norov: introduce a test for
> > > bitmap_cut() that also makes sure functionality is as described for
> > > partially overlapping src and dst.
> >
> > Taking into account recent fixes for BE 64-bit, do we have test cases for a such?
>
> It might be enough to have only these, but perhaps s390 guys can help?
>
> Alexander, can you apply this patch (w/o the first one, which is suppose to
> fix) and confirm that you have test case failure, followed by applying first
> one and confirm a fix?

This failure goes away when patch #1 is applied:

test_bitmap: [lib/test_bitmap.c:666] bitmaps contents differ: expected "0-16,18-19,21,24,26-27,29", got "1,3-4,6,9,11-12,14,16,18-19,21,24,26-27,29"

Thus, I confirm.

[...]

> --
> With Best Regards,
> Andy Shevchenko
>
>