Re: [PATCH 2/9] rcu: Fixup noinstr warnings

[Peter Zijlstra]

On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote:

> >  	// RCU is now watching.  Better not be in an extended quiescent state!
> >  	rcu_dynticks_task_trace_exit();  // After ->dynticks update!
> >  	WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) &&
> >  		     !(seq & RCU_DYNTICK_CTRL_CTR));
> >  	if (seq & RCU_DYNTICK_CTRL_MASK) {
> > -		atomic_andnot(RCU_DYNTICK_CTRL_MASK, &rdp->dynticks);
> > +		arch_atomic_andnot(RCU_DYNTICK_CTRL_MASK, &rdp->dynticks);
> 
> This one is gone in -rcu.

I'm still seeing that in mainline, was that removal scheduled for next
round?

> >  		smp_mb__after_atomic(); /* _exit after clearing mask. */
> >  	}
> >  }

What shall we do with this patch?