Re: [PATCHv2 2/6] power: supply: gpio-charger: Make gpios optional
From: Rob Herring
Date: Mon Jun 15 2020 - 13:50:38 EST
On Sat, 06 Jun 2020 00:43:59 +0200, Sebastian Reichel wrote:
> While strongly recommended, not all devices have a gpio to
> detect if the charger is connected. This moves the 'gpios'
> from required to optional section.
>
> This also modifies error handling for the GPIO a bit: We
> no longer fallback to pdata, if a GPIO is specified using
> GPIO descriptor tables. This is a bit cleaner and does
> not have any real impact: There are only two mainline pdata
> users (arm/mach-sa1100/collie.c, arm/mach-pxa/tosa.c) and
> none of them specify the GPIO via gpiod descriptor tables.
> Once both have been converted the driver's support for
> specifying GPIOs numbers in pdata will be dropped.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
> .../bindings/power/supply/gpio-charger.yaml | 7 +++-
> drivers/power/supply/gpio-charger.c | 38 ++++++++++++-------
> 2 files changed, 31 insertions(+), 14 deletions(-)
>
Acked-by: Rob Herring <robh@xxxxxxxxxx>