Re: [PATCH] scripts/decode_stacktrace: warn when modpath is needed but is unset

[Sasha Levin]

On Mon, Jun 15, 2020 at 03:43:31PM -0700, Linus Torvalds wrote:
> On Mon, Jun 15, 2020 at 3:37 PM Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Well, that looks straightforward.
>
> Hmm. Decided to test it. It warns for every case: a bit excessive,
> perhaps, but I guess it won't hurt.
>
> So Shuah's thing results in
>
> [    9.791367] Call Trace:
> WARNING! Modules path isn't set, but is needed to parse this symbol
> [    9.791377] ? snd_pcm_hw_params+0x3ca/0x440 snd_pcm
> WARNING! Modules path isn't set, but is needed to parse this symbol
> [    9.791383] snd_pcm_common_ioctl+0x173/0xf20 snd_pcm
> WARNING! Modules path isn't set, but is needed to parse this symbol
> [    9.791389] ? snd_ctl_ioctl+0x1c5/0x710 snd
> WARNING! Modules path isn't set, but is needed to parse this symbol
> [    9.791394] snd_pcm_ioctl+0x27/0x40 snd_pcm
>
> which looks a bit redundant, but maybe that just means people _really_ notice.

I figured it's a good balance between warning only once (which can get
lost in a longer trace) vs just exiting on error (as it prevents the
user from ignoring this issue if he doesn't care or just doesn't have
the modules).

--
Thanks,
Sasha