Re: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

[Chen Yu]

On Tue, Jun 16, 2020 at 02:51:27AM +0800, Brown, Aaron F wrote:
> > From: Chen Yu <yu.c.chen@xxxxxxxxx>
> > Sent: Thursday, May 21, 2020 10:59 AM
> > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; David S. Miller
> > <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Kok, Auke-jan H
> > <auke-jan.h.kok@xxxxxxxxx>; Jeff Garzik <jeff@xxxxxxxxxx>
> > Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; Brown, Len <len.brown@xxxxxxxxx>; Rafael J. Wysocki
> > <rjw@xxxxxxxxxxxxx>; Shevchenko, Andriy <andriy.shevchenko@xxxxxxxxx>;
> > Neftin, Sasha <sasha.neftin@xxxxxxxxx>; Lifshits, Vitaly
> > <vitaly.lifshits@xxxxxxxxx>; Chen, Yu C <yu.c.chen@xxxxxxxxx>;
> > Stable@xxxxxxxxxxxxxxx
> > Subject: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device
> > wakeup is disabled
> >
> > Currently the system will be woken up via WOL(Wake On Lan) even if the
> > device wakeup ability has been disabled via sysfs:
> >  cat /sys/devices/pci0000:00/0000:00:1f.6/power/wakeup
> >  disabled
> >
> > The system should not be woken up if the user has explicitly
> > disabled the wake up ability for this device.
> >
> > This patch clears the WOL ability of this network device if the
> > user has disabled the wake up ability in sysfs.
> >
> > Fixes: bc7f75fa9788 ("[E1000E]: New pci-express e1000 driver")
> > Reported-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: <Stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Chen Yu <yu.c.chen@xxxxxxxxx>
> > ---
> >  drivers/net/ethernet/intel/e1000e/netdev.c | 14 ++++++++++----
> >  1 file changed, 10 insertions(+), 4 deletions(-)
> >
> Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>
> 
Thanks for testing, Aaron.

Best,
Chenyu