Re: [ PATCH stable v4.19] EDAC: Drop per-memory controller buses
From: Greg KH
Date: Tue Jun 16 2020 - 06:37:16 EST
On Sun, Apr 05, 2020 at 07:26:01PM +0000, Manali Shukla (manashuk) wrote:
> > On 05/04/20, 11:36 PM, "Borislav Petkov" <bp@xxxxxxx> wrote:
>
> > On Sun, Apr 05, 2020 at 06:01:21PM +0000, Manali Shukla (manashuk) wrote:
> >> With this patch , we are removing per-MC bus, this removes dependency on value of max number of controllers (EDAC_MAX_MCS) which is hardcoded to 2 * MAX_NUMNODES in all stable versions of kernel.
> >> On two nodes system MAX_NUMNODES value is â1â , so value of max number of memory controller becomes â2â, this patch fixes this issue when there are only 2 nodes on the system and number of memory controllers are more than â2'
>
> > You basically repeated what you had written already.
>
> > But what is this fixing? Some platform of yours or what? Why does it
> > need to go to stable?
>
> Certain MIPS platform can have 2 nodes and number of memory controllers can be more than '2' .
>
> for above condition, if
> #define EDAC_MAX_MCS 2 * MAX_NUMNODES,
> it fails in this function edac_mc_add_mc_with_groups
> in below condition
> if (mci->mc_idx >= EDAC_MAX_MCS) {
> pr_warn_once("Too many memory controllers: %d\n", mci->mc_idx);
> return -ENODEV;
> }
> That is why this fix is needed.
What fix?
I see no patch in this email, nor do I see a git commit id anywhere :(
Totally confused,
greg k-h