Re: [PATCH 0/2] Add SW_MACHINE_COVER key

From: Pavel Machek
Date: Tue Jun 16 2020 - 06:50:36 EST


On Fri 2020-06-12 14:53:57, Merlijn Wajer wrote:
> this series adds the sw_machine_cover key, and changes the nokia n900 dts to
> expose the key via gpio-keys.
>
> before, this gpio was used as card detect gpio, causing the card not to show up
> if the phone was booted without cover, see this thread on linux-omap:
>
> n900: remove mmc1 "safety feature"? (was: re: mmc0 on nokia n900 on linux 5.4.18)
>
> since there is no realistic use for using this gpio as card detect, instead
> expose it to userspace via gpio-keys. there are no event type for machine covers
> yet, so add that first.
>
> the key should be 1 when the cover is closed, and 0 when the cover is open.
>
> starting the nokia n900 with the cover removed, putting the cover in place:
>
> event: time 1581684523.415296, type 5 (ev_sw), code 16 (?), value 1
>
> removing the cover again, exposing mmc1 and the battery:
>
> event: time 1581684529.413706, type 5 (ev_sw), code 16 (?), value 0

Looks good to me.

Acked-by: Pavel Machek <pavel@xxxxxx>

Pavel


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html