Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display

[Tomi Valkeinen]

On 15/06/2020 17:53, Adam Ford wrote:
> On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam <festevam@xxxxxxxxx> wrote:
> > On Mon, Jun 15, 2020 at 10:19 AM Adam Ford <aford173@xxxxxxxxx> wrote:
> > > The LogicPD Type28 display used by several Logic PD products has not
> > > worked since v5.5.
> >
> > Maybe you could tell which commit exactly and then put a Fixes tag?
>
> I honestly don't know.  I reached out to the omap mailing list,
> because I noted this issue. Tomi V from TI responded with a link that
> he posted which fixes this for another display.
>
> https://www.mail-archive.com/dri-devel@xxxxxxxxxxxxxxxxxxxxx/msg312208.html
>
> I tested that patch and it worked for a different LCD, so I did the
> same thing to the Logic PD Type 28 display as well.
>
> My patch and commit message were modeled after his, and his commit
> CC's stable with a note about being required for v5.5+
>
> I added him to the CC list, so maybe he knows which hash needs to be
> referenced from a fixes tag.  I was hoping to not have to go back and
> bisect if it's not required, but I will if necessary.

No, I didn't check when exactly it broke. connector_type was added in v5.5, and my patch applies to 
v5.5, so I set that as stable version. But the WARN comes from panel bridge. Possibly 
89958b7cd9555a5d82556cc9a1f4c62fffda6f96 is the one that adds requirement to have connector_type.

 Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki