Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

[Era Mayflower]

On Tue, Jun 16, 2020 at 1:23 AM David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Era Mayflower <mayflowerera@xxxxxxxxx>
> Date: Tue, 16 Jun 2020 00:41:14 +0900
>
> > +     if (tb_sa[MACSEC_SA_ATTR_PN]) {
>
> validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-NULL, so
> you don't need to add this check here.
>

validate_add_rxsa() did not originally contain that requirement.
It does exist in validate_add_txsa(), which means that providing a PN
is necessary only when creating TXSA.
When creating an RXSA without providing a PN it will be set to 1
(init_rx_sa+15).
This is the original behavior which of course can be changed.

- Era.