Re: [Patch v1] i40e: limit the msix vectors based on housekeeping CPUs

From: Nitesh Narayan Lal
Date: Tue Jun 16 2020 - 13:29:47 EST



On 6/16/20 4:03 AM, Christoph Hellwig wrote:
> On Mon, Jun 15, 2020 at 04:21:25PM -0400, Nitesh Narayan Lal wrote:
>> + hk_flags = HK_FLAG_DOMAIN | HK_FLAG_WQ;
>> + mask = housekeeping_cpumask(hk_flags);
>> + cpus = cpumask_weight(mask);
> Code like this has no business inside a driver. Please provide a
> proper core API for it instead.

Ok, I will think of a better way of doing this.

> Also please wire up
> pci_alloc_irq_vectors* to use this API as well.

Understood, I will include this in a separate patch.

>
--
Thanks
Nitesh

Attachment: signature.asc
Description: OpenPGP digital signature