Re: [PATCH v1] ARM: bcm2835: Fix integer overflow in rpi_firmware_print_firmware_revision()

[Petr Mladek]

On Tue 2020-06-16 18:42:00, Nicolas Saenz Julienne wrote:
> On Tue, 2020-06-16 at 19:31 +0300, Andy Shevchenko wrote:
> > time64_t is 64-bit width type, we are not supposed to supply lesser ones
> > as in the case of rpi_firmware_print_firmware_revision() after the commit
> > 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT"). Use temporary variable
> > of time64_t type to correctly handle lesser types.
> > 
> > Fixes: 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT")
> > Reported-by: Stefan Wahren <wahrenst@xxxxxxx>
> > Reported-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: Petr Mladek <pmladek@xxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> > ---
> 
> Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
> Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>

Revieved-by: Petr Mladek <pmladek@xxxxxxxx>

> If this doesn't fit the printk tree I don't mind taking it trough the rpi soc
> tree.
> 
> I'll also update the MAINTAINERS file so the firmware driver isn't orphaned.

I agree with Sergey that this should better go via SOC tree.

That said, feel free to ask to take it via printk tree. It has caused
the regression after all ;-)

Best Regards,
Petr